[teststabilization] RFR: 8224761: Replace wildcard address with loopback or local host in tests - part 12

Daniel Fuchs daniel.fuchs at oracle.com
Mon May 27 09:49:39 UTC 2019


Thanks Vyom,

On 27/05/2019 10:32, Vyom Tewari26 wrote:
> Overall changes looks good to me, in "B6726695.java" you have used 
> ".loopback()" which is not consistent with the other similar URL 
> construction changes although i can see that "ProxyTest.java" uses 
> ".loopback()" as well.

Yes consistency is not that important here.
Sometimes you have the server/server socket address available
and can use that. Sometimes it's not directly available
unless you modify the test to pass it - in which case
using loopback() when you know that the server is
bound to the loopback is also acceptable.

best regards,

-- daniel


More information about the net-dev mailing list