[RFR] 8224645: Test java/nio/channels/DatagramChannel/BasicMulticastTests.java fails with NoSuchElementException
Daniel Fuchs
daniel.fuchs at oracle.com
Wed May 29 09:32:29 UTC 2019
On 29/05/19 09:19, Chris Hegarty wrote:
> This already exists.
> NetworkConfiguration.printSystemConfiguration(PrintStream)
>
> I think there needs to be a balance between readability and
> diagnosability. It's often the case that much debugging statements are
> added to a test when investigating a failure. It's good to have some
> breadcrumbs to follow when things go wrong, but it should not complicate
> the code too much.
>
> It might be useful to just unconditionally printSystemConfiguration, at
> the start of the test, and then the nic in use for each iteration. I
> don't think anything more is needed.
+1
For the record I ran Arthur's webrev.01 through our test system and
got no failures (just tested BasicMulticastTests.java).
best regards,
-- daniel
More information about the net-dev
mailing list