RFR [13] 8224730: java.net.ServerSocket::toString not invoking checkConnect

Alan Bateman Alan.Bateman at oracle.com
Wed May 29 11:50:37 UTC 2019


On 29/05/2019 12:36, Chris Hegarty wrote:
>
> Good idea. I've expanded the test to cover the ServerSocket adapter too.
> Good news is that it found no issues ( but of course will increase
> coverage and catch possible future accidental breakages ).
>
> Webrev:
>   https://cr.openjdk.java.net/~chegar/8224730/webrev.01/
One suggestion is to rename the socketAdapterXXX methods to 
serverSocketAdaptorXXX to align with the class name. Otherwise looks good.

>
> CSR - to cover the minor spec clarification:
>   https://bugs.openjdk.java.net/browse/JDK-8224972
>
I've added myself as Reviewer to the CSR.

-Alan



More information about the net-dev mailing list