[teststabilization] RFR: 8233403: Improve verbosity of some httpclient tests

Chris Hegarty chris.hegarty at oracle.com
Tue Nov 5 15:25:20 UTC 2019



> On 5 Nov 2019, at 14:45, Daniel Fuchs <daniel.fuchs at oracle.com> wrote:
> 
> Hi Chris,
> 
> Thanks for the review! Meanwhile one of the test jobs I had
> launched completed and showed one of the intermittent
> SortRequestBody failures - and I was able to see the root
> cause!

Great.

> It is a test bug: the server uses a counter to figure out
> what result the client will expect in its next response, and
> I could see that this counter got de-synchronized: the client
> sent 42 requests but the counter got incremented only 41 times
> and that caused the test for the next supplier to fail in
> timeout (see traces below). So I've taken the opportunity
> to fix that in the test as well.


So the server is getting a connection from “something else” on on the network, and your changes protect against that, right? Is there any value, from a diagnostic point of view, to emitting whatever “unexpected” data is received?

> 
> http://cr.openjdk.java.net/~dfuchs/webrev_8233403/webrev.01/


The changes look fine..

-Chris. 


More information about the net-dev mailing list