RFR[8234103]: DatagramSocketImpl::socket is not needed

Alan Bateman Alan.Bateman at oracle.com
Thu Nov 14 13:43:27 UTC 2019


On 14/11/2019 11:58, Patrick Concannon wrote:
> Hi,
>
> Could someone please review my fix for issue JDK-8234103 
> 'DatagramSocketImpl::socket is not needed' ?
>
> DatagramSocketImpl has a socket field that links back to the 
> DatagramSocket, which is only used to determine whether this 
> DatagramSocket support Multicast or not. This fix removes the 
> DatagramSocket object and replaces it with a boolean 'isMulticast' 
> field in AbstractPlainDatagramSocketImpl.
>
> bug: https://bugs.openjdk.java.net/browse/JDK-8234103
> webrev: http://cr.openjdk.java.net/~pconcannon/8234103/webrevs/webrev.00/
This looks a good clean-up to me.

-Alan


More information about the net-dev mailing list