RFR[8234083]: DatagramSocket should report SO_BROADCAST as a supported option

Alan Bateman Alan.Bateman at oracle.com
Fri Nov 15 13:16:50 UTC 2019



On 15/11/2019 13:13, Patrick Concannon wrote:
> Hi,
>
>
> Could someone please review my fix for issue JDK-8234083 
> 'DatagramSocket should report SO_BROADCAST as a supported option'?
>
> DatagramSocket has setBroadcast/getBroadcast methods, but omits 
> SO_BROADCAST as a supported option. This fix adds SO_BROADCAST as a 
> valid option, and updates OptionsTest.java to reflect this addition.
>
> As this change effects the source - the options are added to 
> AbstractPlainDatagramSocketImpl - I was wondering if a CSR would be 
> needed?
>
> bug: https://bugs.openjdk.java.net/browse/JDK-8234083
>
> webrev: http://cr.openjdk.java.net/~pconcannon/8234083/webrevs/webrev.00/
Looks good, you might want to add the bug number to the @bug tag before 
pushing.

-Alan


More information about the net-dev mailing list