RFR: [XS] 8234501 : remove obsolete NET_ReadV
Baesken, Matthias
matthias.baesken at sap.com
Thu Nov 21 07:38:01 UTC 2019
Thanks !
May I have a second review ?
Best regards, Matthias
From: Vyom Tewari26 <vtewar26 at in.ibm.com>
Sent: Donnerstag, 21. November 2019 05:01
To: Baesken, Matthias <matthias.baesken at sap.com>
Cc: net-dev at openjdk.java.net
Subject: Re: RFR: [XS] 8234501 : remove obsolete NET_ReadV
looks OK to me, i searched through entire JDK code base and i did not found any uses of "NET_ReadV" .
Thanks,
Vyom
----- Original message -----
From: "Baesken, Matthias" <matthias.baesken at sap.com<mailto:matthias.baesken at sap.com>>
Sent by: "net-dev" <net-dev-bounces at openjdk.java.net<mailto:net-dev-bounces at openjdk.java.net>>
To: "net-dev at openjdk.java.net<mailto:net-dev at openjdk.java.net>" <net-dev at openjdk.java.net<mailto:net-dev at openjdk.java.net>>
Cc:
Subject: [EXTERNAL] RFR: [XS] 8234501 : remove obsolete NET_ReadV
Date: Wed, Nov 20, 2019 7:10 PM
Hello, please review this small cleanup .
While experimenting with “link time gc” (-Wl,--gc-sections -Wl,--print-gc-sections options [1]), a feature that can help you identify and eliminate unused coding,
I noticed that NET_ReadV is found and marked as unused/dead code. So it should probably be removed from the codebase .
Bug/webrev:
https://bugs.openjdk.java.net/browse/JDK-8234501
http://cr.openjdk.java.net/~mbaesken/webrevs/8234501.0/
[1] https://linux.die.net/man/1/ld
Best regards, Matthias
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://mail.openjdk.java.net/pipermail/net-dev/attachments/20191121/4ee790f7/attachment-0001.html>
More information about the net-dev
mailing list