RFR[8233307]: MulticastSocket getOption(IP_MULTICAST_IF) returns interface when not set
Chris Hegarty
chris.hegarty at oracle.com
Thu Nov 28 14:46:46 UTC 2019
> On 28 Nov 2019, at 13:01, Patrick Concannon <patrick.concannon at oracle.com> wrote:
>
> Hi Chris,
>
> Thanks for your feedback.
>
> I've incorporated your comments into the fix, and the changes can be found in the updated webrev below.
>
> webrev: http://cr.openjdk.java.net/~pconcannon/8233307/webrevs/webrev.02/
Looks good.
Instead of :
} catch (IOException e) {
throw new RuntimeException(e);
}
maybe throw UncheckedIOException. ( Hmm… I see that my comment is no longer relevant! ( update in-place? )
I do not need to see another webrev. You have my Review.
-Chris.
More information about the net-dev
mailing list