RFR[8222829]: DatagramSocket.setSoTimeout does not specify IAE when timeout is negative

Chris Hegarty chris.hegarty at oracle.com
Thu Oct 3 15:11:34 UTC 2019



> On 2 Oct 2019, at 16:54, Patrick Concannon <patrick.concannon at oracle.com> wrote:
> 
> Hi,
> 
> I've updated the webrev following feedback received here, and from the CSR on this issue.
> 
> webrev: http://cr.openjdk.java.net/~pconcannon/8222829/webrevs/webrev.02/
> 

Mainly looks good.

Trivially, there are superfluous parentheses around the exception message string:

    throw new IllegalArgumentException(("timeout < 0"));

No need to re-generate the webrev.

-Chris.


More information about the net-dev mailing list