RFR: 8231632: HttpURLConnection::usingProxy could specify that it may lazily evaluate the fact

Chris Hegarty chris.hegarty at oracle.com
Fri Oct 18 15:36:02 UTC 2019



> On 18 Oct 2019, at 15:30, Julia Boes <julia.boes at oracle.com> wrote:
> 
> 
> 1) Maybe add @Override to `public boolean usingProxy()`. ( pre-existing issue )
> 
> 2) Maybe move the return on 3040 to a new line. Also use the curly braces consistently, or not at all ;-)
> 
> That's right! Thanks for reviewing, Chris. I added those two changes.
> 
> Updated webrev: http://cr.openjdk.java.net/~jboes/webrevs/8231632/webrev.02/index.html

LGTM.

-Chris.


More information about the net-dev mailing list