RFR[8230132]: java/net/NetworkInterface/NetworkInterfaceRetrievalTests.java to skip Teredo Tunneling Pseudo-Interface

Aleks Efimov aleksej.efimov at oracle.com
Mon Sep 2 13:29:45 UTC 2019


Hey Patrick,

Looks good to me!

You could utilize jdk.test.lib.Platform::isWindows from test library to 
check if the test is running on Windows platform.

With Best Regards,
Aleksei

On 29/08/2019 16:01, Patrick Concannon wrote:
>
> Hi,
>
> Would it be possible to have my fix for JDK-8230132 reviewed?
>
> java/net/NetworkInterface/NetworkInterfaceRetrievalTests.java was 
> failing intermittently on Windows due to random addresses being 
> returned from the virtual interface "Teredo Tunneling 
> Pseudo-Interface". The fix checks for, and skips, these interfaces - 
> as was done for JDK-8038276. 
> <https://bugs.openjdk.java.net/browse/JDK-8038276>
>
> Further information on this bug can be found here: 
> https://bugs.openjdk.java.net/browse/JDK-8230132
>
> Webrev for fix: 
> http://cr.openjdk.java.net/~dfuchs/pconcann/8230132/webrevs/webrev.1/
>
> Kind regards,
> Patrick
>
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://mail.openjdk.java.net/pipermail/net-dev/attachments/20190902/4aec85ca/attachment.html>


More information about the net-dev mailing list