RFR: 8171405: java/net/URLConnection/ResendPostBody.java failed with "Error while cleaning up threads after test"

[Julia Boes]

Hi,

Thanks for the review, Michael and Vyom. I removed server.close() from 
the run method.

Updated webrev: http://cr.openjdk.java.net/~dfuchs/jboes/8171405/webrev.03/

Regards,

Julia

On 01/09/2019 06:07, Vyom Tewari26 wrote:
> Hi Julia,
> Thanks for fixing this test issue, in your modified code server will 
> get closed twice once in main thread(server.setFinished(true);) and 
> once in server run method. Please  close server if it is already not 
> closed(if (!server.isClosed()) { server.close();}) or remove 
> server.close() from run method.
> Rest of changes looks good to me.
> Thanks,
> Vyom
>
>     ----- Original message -----
>     From: Julia Boes <julia.boes at oracle.com>
>     Sent by: "net-dev" <net-dev-bounces at openjdk.java.net>
>     To: net-dev at openjdk.java.net
>     Cc:
>     Subject: [EXTERNAL] RFR: 8171405:
>     java/net/URLConnection/ResendPostBody.java failed with "Error
>     while cleaning up threads after test"
>     Date: Thu, Aug 29, 2019 10:34 PM
>     Hi,
>
>     This fix involves a test that failed during thread cleanup. To address
>     this, the ServerSocket is now being closed at the end and the server
>     thread is joined. While at it, I removed some unnecessary whitespace.
>
>     webrev: http://cr.openjdk.java.net/~dfuchs/jboes/8171405/webrev.02/
>
>     bug report: https://bugs.openjdk.java.net/browse/JDK-8171405
>
>     Cheers,
>
>     Julia
>
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://mail.openjdk.java.net/pipermail/net-dev/attachments/20190902/9a9bc25e/attachment.html>