RFR[8230159]: Add test to verify that com.sun.net.httpserver.BasicAuthenticator constructors throw expected exceptions

Patrick Concannon patrick.concannon at oracle.com
Wed Sep 4 11:11:18 UTC 2019


Hi Vyom,

Thanks for the feedback. I've made the change as requested, and it can 
be found in the new webrev below.

http://cr.openjdk.java.net/~dfuchs/pconcann/8230159/webrevs/webrev.3/


Kind regards,

Patrick

On 03/09/2019 14:31, Vyom Tewari26 wrote:
> Hi Patrick,
> New test looks good to me, minor bit jtreg tag order in not correct ,  
> generally @run tag comes last.
> Thanks,
> Vyom
>
>     ----- Original message -----
>     From: Daniel Fuchs <daniel.fuchs at oracle.com>
>     Sent by: "net-dev" <net-dev-bounces at openjdk.java.net>
>     To: Patrick Concannon <patrick.concannon at oracle.com>, OpenJDK
>     Network Dev list <net-dev at openjdk.java.net>
>     Cc:
>     Subject: [EXTERNAL] Re: RFR[8230159]: Add test to verify that
>     com.sun.net.httpserver.BasicAuthenticator constructors throw
>     expected exceptions
>     Date: Tue, Sep 3, 2019 3:34 PM
>     Thanks for the new test Patrick!
>
>     It looks good to me.
>
>     best regards,
>
>     -- daniel
>
>     On 02/09/2019 11:23, Patrick Concannon wrote:
>     > https://bugs.openjdk.java.net/browse/JDK-8230159
>     >
>     > Webrev for fix:
>     >
>     http://cr.openjdk.java.net/~dfuchs/pconcann/8230159/webrevs/webrev.2/
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://mail.openjdk.java.net/pipermail/net-dev/attachments/20190904/250e5762/attachment.html>


More information about the net-dev mailing list