(teststabilization) RFR: 8231506: Fix some instabilities in a few networking tests

Alan Bateman Alan.Bateman at oracle.com
Thu Sep 26 15:43:51 UTC 2019



On 26/09/2019 15:16, Daniel Fuchs wrote:
> Hi,
>
> Please find below a patch for:
>
> https://bugs.openjdk.java.net/browse/JDK-8231506
> 8231506: Fix some instabilities in a few networking tests
>
> webrev:
> http://cr.openjdk.java.net/~dfuchs/webrev_8231506/webrev.00/
>
In SocketImplCombinations, the update to testNewSocket2 looks good. My 
fault that it didn't originally use the loopback address. I assume the 
rest of the changes to the test aren't really needed as the changes are 
to tests that don't involve a connection (the tests are mostly checking 
that accept fails due to a SocketImpl mismatch). No objection to the 
changes but if you do include them then loopbackAddress should probably 
be renamed to loopbackSocketAddress to avoid confusing readers (as it 
returns a SocketAddress rather than the InetAddress for the loopback 
address).

-Alan


More information about the net-dev mailing list