RFR[8241072]: 'Reimplement Legacy DatagramSocket API'
Alan Bateman
Alan.Bateman at oracle.com
Tue Apr 14 09:34:18 UTC 2020
On 14/04/2020 10:20, Daniel Fuchs wrote:
>
> That's where I disagree because it's a slight difference in behavior
> between the old implementation and the new - so I believe it's worth
> having a test for it (even if does test the presence of a bug in the
> old impl). I like this test because it does show how
> every implementation behaves in one single place without having
> to forage in every other test hierarchy to figure what their
> behaviors are. The branch is the only place where you could have
> such a test (since the new impl is only available here).
Can you create a bug to fix PDSI? It should be a trivial change to
datagramSocketCreate. That would be the issue to add a test to make sure
that the initial value of SO_SNDBUF is >= 65537 and avoid creating
technical debt by adding a test that checks the wrong initial size.
-Alan
More information about the net-dev
mailing list