RFR 8242999: http/2 client may not handle continuation frames correctly

Chris Hegarty chris.hegarty at oracle.com
Mon Apr 27 10:29:02 UTC 2020


Rahul,

> On 24 Apr 2020, at 15:58, Rahul <rahul.r.yadav at oracle.com> wrote:
> 
> Hello,
>  
>   Request to have my fix reviewed for the issue:
>   JDK-8242999 :  http/2 client may not handle continuation frames correctly.
>    
>   The fix updates jdk.internal.net.http.Stream.incoming(Http2Frame frame) to handle
>   the scenario where a continuation with `END_HEADERS` may appear after a header
>   frame, this was not being handled earlier.
>    
>          Issue:       https://bugs.openjdk.java.net/browse/JDK-8242999
>          Webrev:  http://cr.openjdk.java.net/~pconcannon/rayayada/8242999/webrevs/webrev.00/
> 

Looks good.

Can you please update the comment in the test. Suggest:

  * A function that returns a list of 1) a HEADERS frame WITH END_STREAM
  *( AND an empty payload ), and 2) two CONTINUATION frames, THE FIRST
  * is empty and THE SECOND with headers AND END_HEADERS.

-Chris.




More information about the net-dev mailing list