Re: RFR[8243507]: 'DatagramSocket constructors don’t always specify what happens when passed invalid parameters'

Daniel Fuchs daniel.fuchs at oracle.com
Wed Apr 29 20:27:51 UTC 2020


On 29/04/2020 21:08, Patrick Concannon wrote:
> webrev: http://cr.openjdk.java.net/~pconcannon/8243507/webrevs/webrev.01/

Thanks Patrick. LGTM.

Pedantically, this test might temporarily leak instances
of DatagramSocket when it detects a bug. That is, for
instance - in the case where `new DatagramSocket(-1)`
were buggy and would not throw. But as I'm confident that
should never happen, and as modifying the test to cater
for that would be quite ugly, let's leave it as is.

best regards,

-- daniel



More information about the net-dev mailing list