RFR(s): Improving performance of Windows socket connect on the loopback adapter

[Alan Bateman]

On 04/08/2020 16:36, Nikola Grcevski wrote:
> Hi Alan,
>
>> What cheap is VerifyVersionInfoW? The check is done everytime but the overhead might be in the noise. Overall it looks good to me.
> I wrote a small benchmark to measure the overhead of the version check (attached below).
>
> On my SurfaceBook 2 running Windows 10 Build 19041, the version check measures about ~2.2us (micro seconds) on average, when the
> version matches.
>
> Elapsed time 2244us. (for 1,000 iterations)
>
> On a Windows 2016 Data Center Server the version check is much smaller ~0.13us (micro seconds) on average, when the version doesn't
> match.
>
> Elapsed time 128us. (for 1,000 iterations)
>
> I think the overhead is reasonably small compared to everything else. Please let me know if it's acceptable and if we can proceed.
>
>
Okay. So do you me to sponsor this?

-Alan