RFR: JDK-8212035 : merge jdk.test.lib.util.SimpleHttpServer with jaxp.library.SimpleHttpServer [v2]

Mahendra Chhipa github.com+34924738+mahendrachhipa at openjdk.java.net
Tue Dec 8 16:51:09 UTC 2020


On Fri, 4 Dec 2020 20:45:24 GMT, Daniel Fuchs <dfuchs at openjdk.org> wrote:

>> Mahendra Chhipa has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   Implemented the review comments.
>
> test/lib/jdk/test/lib/net/SimpleHttpServer.java line 95:
> 
>> 93:         return _httpserver.getAddress().getPort();
>> 94:     }
>> 95: 
> 
> There are many issues with this class - using "localhost" and binding to the wildcard address among others. 
> Having instance variables that are not final but are accessed by potentially multiple threads is another. 
> I could also mention not using try-with-resources or the odd _name convention.
> It will need to be modernized if you want to put it in jdk.test.lib.net;

Thanks. Now this class is modernized in next patch.

-------------

PR: https://git.openjdk.java.net/jdk/pull/1632


More information about the net-dev mailing list