RFR: 8258422: Cleanup unnecessary null comparison before instanceof check in java.base [v4]
Alan Bateman
alanb at openjdk.java.net
Thu Dec 17 10:33:00 UTC 2020
On Wed, 16 Dec 2020 10:32:12 GMT, Andrey Turbanov <github.com+741251+turbanoff at openjdk.org> wrote:
>> 8258422: Cleanup unnecessary null comparison before instanceof check in java.base
>
> Andrey Turbanov has updated the pull request incrementally with one additional commit since the last revision:
>
> 8258422: Cleanup unnecessary null comparison before instanceof check in java.base
> take advantage of "flow scoping" to eliminate casts
src/java.base/share/classes/jdk/internal/misc/Signal.java line 102:
> 100: */
> 101: public boolean equals(Object other) {
> 102: if (this == other) {
It might be a bit cleaner to rename Object other to "obj" to avoid having Object other and Signal other1.
-------------
PR: https://git.openjdk.java.net/jdk/pull/20
More information about the net-dev
mailing list