RFR: 8257736: InputStream from BodyPublishers.ofInputStream() leaks when IOE happens [v4]
Yasumasa Suenaga
ysuenaga at openjdk.java.net
Fri Dec 18 08:11:00 UTC 2020
On Sat, 5 Dec 2020 04:55:56 GMT, Yasumasa Suenaga <ysuenaga at openjdk.org> wrote:
>> Hi Yasumasa,
>>
>> Thanks for filing the issue and providing a fix.
>>
>> Before integrating, can you please provide a non regression test that verifies the fix? You can place it in `test/jdk/java/net/httpclient/`;
>> Please also make sure that there is no regression in existing tests.
>>
>> best regards
>> -- daniel
>
> @dfuch Thanks for your comment! I updated PR.
>
> * Close the stream in `StreamIterator::hasNext`
> * Throw `UncheckedIOException` whenever IOE happens
> * Added testcase for this PR
>
> Could you review again?
@ChrisHegarty @dfuch could you review new change? It updates a testcase.
-------------
PR: https://git.openjdk.java.net/jdk/pull/1614
More information about the net-dev
mailing list