RFR: JDK-8257235: [PATCH] InetAddress.isReachable: Try to use an IPPROTO_ICMP socket type before attempting RAW_SOCK [v2]

[Jamie Le Tual]

On Tue, 22 Dec 2020 14:08:26 GMT, Alan Bateman <alanb at openjdk.org> wrote:

> Adding support for SOCK_DGRAM/IPPROTO_ICMP(6) is good and I think is mostly okay. The comments and the formatting is messy in several places and should be cleaned up before the patch is sponsored.

Alan, thanks for taking a look at the patch. I tried to see which comments and  formatting where messy and I have to say I don't see what your are talking about; as far as I can tell the formatting in the patch doesn't diverge from the code style of the files they are in.  Can you give a specific example of what you consider messy so I can know what you're talking about?

-------------

PR: https://git.openjdk.java.net/jdk/pull/1502