8239052: java/net/httpclient/whitebox/SSLEchoTubeTestDriver.java failed with BufferUnderflowException against TLSv1.3

[sha.jiang at oracle.com]

Hi Daniel,
Not a review, but just a minor suggestion.

273         params.setProtocols(new String[]{"TLSv1.3"}); // TODO: This 
is essential. Needs to be protocol impl
If this test doesn't concern a specific TLS protocol, this configuration 
could be removed.
The default TLS protocol, exactly TLSv1.3 now, will be applied.

Best regards,
John Jiang

On 2020/2/21 18:01, Daniel Fuchs wrote:
> Hi,
>
> Please find below a test fix for:
>
> 8239052: java/net/httpclient/whitebox/SSLEchoTubeTestDriver.java
>          failed with BufferUnderflowException against TLSv1.3
> https://bugs.openjdk.java.net/browse/JDK-8239052
>
> webrev:
> http://cr.openjdk.java.net/~dfuchs/webrev_8239052/webrev.00/
>
> The test throws a BufferUnderflowException because it oversaw
> the fact that the buffers delivered from upstream are not
> necessary split at 8 bytes boundaries.
> The test code tries to read a long but the long can be
> split over several buffers.
>
> The fix simply adds a carry too carry over trailing bytes
> from one buffer to the next.
> It also changes AbstractSSLTubeTest.java to use TLSv1.3.
>
> best regards,
>
> -- daniel