RFR: 8236859: WebSocket over authenticating proxy fails with NPE

Pavel Rappo pavel.rappo at oracle.com
Tue Jan 14 15:22:25 UTC 2020


That patch contains the following lines:

--- old/test/jdk/java/net/httpclient/websocket/DummyWebSocketServer.java        2020-01-13 13:04:41.000000000 +0000
+++ /dev/null   2020-01-13 13:04:41.000000000 +0000

--- old/test/jdk/java/net/httpclient/websocket/Support.java     2020-01-13 13:04:44.000000000 +0000
+++ /dev/null   2020-01-13 13:04:44.000000000 +0000

If I'm reading this right, those two files are considered removed. Is it
possible to produce the patch once again with, maybe using "--git" option this
time?

Thanks!

> On 14 Jan 2020, at 15:14, Daniel Fuchs <daniel.fuchs at oracle.com> wrote:
> 
> Hi Pavel,
> 
> That's strange. Are you sure your hg import worked properly?
> Note that SecureSupport is a modified copy of Support
> (not a rename) and DummySecureWebSocketServer is a
> modified copy of DummyWebSocketServer (not a rename).
> 
> I wonder if this was causing issue with the import.
> (the patch is obtained by hg diff, not hg export)
> 
> best regards,
> 
> -- daniel
> 
> On 14/01/2020 14:39, Pavel Rappo wrote:
>> Daniel,
>> I imported the patch from the link you provided as follows:
>>     hg import --no-commit open.patch
>> The patch applied successfully. I tried then to run the tests and saw that some
>> of them could not be compiled. For instance,
>>     java/net/httpclient/websocket/BlowupOutputQueue.java
>>     java/net/httpclient/websocket/PendingPingBinaryClose.java
>>     ...
>> etc.
> > On 13 Jan 2020, at 13:06, Daniel Fuchs <daniel.fuchs at oracle.com> wrote:
> >> http://cr.openjdk.java.net/~dfuchs/webrev_8236859/webrev.00/
> 



More information about the net-dev mailing list