8238231: Custom DatagramSocketImpl's create method not called when with protected constructor
Alan Bateman
Alan.Bateman at oracle.com
Fri Jan 31 20:45:45 UTC 2020
On 31/01/2020 19:42, Daniel Fuchs wrote:
>
> I think I disagree but I agree it's non obvious so I will switch
> the boolean to volatile.
> http://cr.openjdk.java.net/~dfuchs/webrev_8238231/webrev.02
Good, this version is correct. I see that getImpl() is synchronizing on
"this". I guess that is okay but synchronizing on the impl is another
choice here.
Did you mean to include the SetReceiveBufferSize test in this webrev?
The change is okay but if we are touching that test then it would be
better to change it to try-with-resources.
-Alan
More information about the net-dev
mailing list