8248703 Clarify the behavior of java.net.NetworkInterface::equals

[Alan Bateman]

On 02/07/2020 14:12, Daniel Fuchs wrote:
> Hi,
>
> Please find below a fix for
>
> 8248703 Clarify the behavior of java.net.NetworkInterface::equals
> https://bugs.openjdk.java.net/browse/JDK-8248703
>
> CSR:    https://bugs.openjdk.java.net/browse/JDK-8248704
> webrev: http://cr.openjdk.java.net/~dfuchs/webrev_8248703/webrev.00/
>
> NetworkInterface::equals is specified to compare the interface names 
> and raw IP addresses. However, on some systems, some interface 
> addresses can be dynamically updated while an application is running. 
> Two NetworkInterface objects may therefore compare unequal even though 
> they represent the same logical underlying interface.
>
> both fix and CSR need reviewers.
I assume the "Note" can be an @apiNote. I think that part reads okay 
(and doesn't a CSR).

NetworkInterface is currently spec'ed to use phrases like "InetAddresses 
bound to the network interface" and I think we should try to keep that 
consistent if possible. That is, introducing the term "raw" into the 
javadoc would require it to be defined and I don't think we need it. 
Also some reader might think it has something to do with "raw sockets".

-Alan