Re: RFR[8242885]: 'PlainDatagramSocketImpl doesn’t allow for the sending of IPv6 datagrams on macOS with sizes between 65508-65527 bytes'

[Patrick Concannon]

Hi,

Sorry for the delay.

Alan: I’ve changed `testInitialSendBufferSize` in the test `test/java/net/DatagramSocket/SetGetSendBufferSize.java` to now check the limit when the socket is IPv6 only. I’ve also updated the tests to be end-to-end (rather than use the loopback) as requested. 

Vyom: I’ve updated the fix to use int constants now in place of values. 

webrev: http://cr.openjdk.java.net/~pconcannon/8242885/webrevs/webrev.01/ <http://cr.openjdk.java.net/~pconcannon/8242885/webrevs/webrev.01/>

Kind regards,
Patrick

> On 10 May 2020, at 14:32, Vyom Tiwari <vyommani at gmail.com> wrote:
> 
> Looks good to me, minor comment can you please use some int constant  in place of (65527, 65507) ?.
> Vyom
> 
> On Fri, May 8, 2020 at 7:19 PM Patrick Concannon <patrick.concannon at oracle.com <mailto:patrick.concannon at oracle.com>> wrote:
> Hi,
> 
> Could someone please review my fix for JDK-8242885 
> 'PlainDatagramSocketImpl doesn’t allow for the sending of IPv6 datagrams 
> on macOS with sizes between 65508-65527 bytes'?
> 
> This fix changes the current max size for IPv6 datagrams on macOS from 
> it's current size of 65507, which is the IPv4 limit, to65527, the actual 
> limit for IPv6 on macOS. This will get around the issue of not being 
> able to send datagrams with sizes between65508-65527 bytes.
> 
> bug: https://bugs.openjdk.java.net/browse/JDK-8242885 <https://bugs.openjdk.java.net/browse/JDK-8242885>
> webrev: http://cr.openjdk.java.net/~pconcannon/8242885/webrevs/webrev.00/ <http://cr.openjdk.java.net/~pconcannon/8242885/webrevs/webrev.00/>
> 
> 
> Kind regards,
> 
> Patrick
> 
> 
> 
> -- 
> Thanks,
> Vyom

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://mail.openjdk.java.net/pipermail/net-dev/attachments/20200709/2a277e52/attachment.htm>