RFR 8237858: PlainSocketImpl.socketAccept() handles EINTR incorrectly

[Daniel Fuchs]

Hi Vyom,

I don't know if that's what Alan is referring to but I see
this:

bsd_close.c:

missing space just after `if` extra space just before `timeout`:
  475             if( timeout > 0) {

linux_close.c:

missing space just after `if`:
  440             if(timeout > 0) {

missing space just after else:
  447             }else {

best regards,

-- daniel

On 15/07/2020 09:14, Vyom Tiwari wrote:
> Hi Alan,
> 
> thanks for the review, I will definitely fix any formatting issue before 
> pushing the patch. My local repo code is properly formatted and i was 
> suspecting that  webrev is ignoring the space  while generating the 
> patch file that's why you are seeing the formatting issue.
> 
> My local code is properly formatted  and i am assuming that while 
> pushing there will not be any formatting issue.
> 
> Please let me know if I am missing something.
> 
> thanks,
> Vyom
> 
> On Wed, Jul 15, 2020 at 12:44 AM Alan Bateman <Alan.Bateman at oracle.com 
> <mailto:Alan.Bateman at oracle.com>> wrote:
> 
> 
> 
>     On 14/07/2020 20:09, Daniel Fuchs wrote:
>      > On 12/07/2020 07:36, Vyom Tiwari wrote:
>      >> Hi Patrick,
>      >>
>      >> Thanks for testing, Alan, Daniel can i get the final  review
>     comment
>      >> from you both ?.
>      >>
>      >
>      > Hi Vyom,
>      >
>      > http://cr.openjdk.java.net/~vtewari/8237858/webrev1.0/index.html
>     Vyom - will you fix the formatting issues in linux_close.c and
>     bsd_close.c before you push this? You mentioned that it's a webrev
>     issue
>     but I don't think so because they are in the patch file too.
> 
>     -Alan
> 
> 
> 
> -- 
> Thanks,
> Vyom