Re: RFR[8242885]: 'PlainDatagramSocketImpl doesn’t allow for the sending of IPv6 datagrams on macOS with sizes between 65508-65527 bytes'
Alan Bateman
Alan.Bateman at oracle.com
Thu Jul 30 12:20:03 UTC 2020
On 30/07/2020 10:56, Patrick Concannon wrote:
> Hi Daniel,
>
> Thanks for your reply.
>
> I’ve made the changes you’ve requested and you can find them in the updated webrev below.
>
> http://cr.openjdk.java.net/~pconcannon/8242885/webrevs/webrev.02/
>
DatagramChannel/SendReceiveMaxSize.java. I think the @summary should be
changed to make it clear that it tests send and receiving datagrams of
maximum size (it's no longer a test for SO_SNDBUF) Also in
testSendReceiveMaxSize it would be clear if "r" and "s" could be renamed
to "receiver" and "sender" (there's overuse of var in this method so
important to use good names).
-Alan
More information about the net-dev
mailing list