RFR: 8246431: java/net/httpclient/PathSubscriber tests fail due to missing FilePermission

Chris Hegarty chris.hegarty at oracle.com
Fri Jun 5 09:00:45 UTC 2020


Julia,

> On 4 Jun 2020, at 17:24, Julia Boes <julia.boes at oracle.com> wrote:
> 
> Hi,
> 
> The tests in java/net/httpclient/PathSubscriber don't grant certain file permissions to test library classes. The tests succeed by chance when the compiled library classes are placed under ${test.classes}, but occasionally they fail, depending on which test target compiles the library first. This fix adds a FilePermission to the test/lib code base to cover all cases.
> 
> Bug: https://bugs.openjdk.java.net/browse/JDK-8246431
> 
> Webrev: http://cr.openjdk.java.net/~jboes/webrevs/8246431/webrev.00/

I think this looks fine as is. Optionally...

1) The preceding line ( to that of the new permission grant ) would appear to no longer be needed, since the new permission grant is to ALL-FILES, but its presence should be benign.

2) The comment "// for JTwork/classes/0/test/lib/jdk/test/lib/net/SimpleSSLContext.class”, could be generalised, since the codebase and permissions are for several library classes, not just SimpleSSLConext.

-Chris.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://mail.openjdk.java.net/pipermail/net-dev/attachments/20200605/fd5ba08f/attachment.htm>


More information about the net-dev mailing list