Re: RFR[8244933]: ‘DatagramSocket.connect does not specify that it may cause datagrams in the socket receive buffer to be discarded’
Alan Bateman
Alan.Bateman at oracle.com
Tue Jun 9 14:47:57 UTC 2020
On 09/06/2020 15:42, Patrick Concannon wrote:
> Hi,
>
> Could someone please review my fix for JDK-8244933 -
> ‘DatagramSocket.connect does not specify that it may cause datagrams
> in the socket receive buffer to be discarded’ ?
>
> Currently, the javadoc for `DatagramSocket.connect` doesn't specify
> that it may cause datagrams in the socket receive buffer to be
> discarded if not previously received via a call
> to `DatagramSocket.receive`. This fix updates the javadoc to inform
> the user of this behaviour.
>
> issue: https://bugs.openjdk.java.net/browse/JDK-8244933
> webrev: http://cr.openjdk.java.net/~pconcannon/8244933/webrevs/webrev.00/
> csr: https://bugs.openjdk.java.net/browse/JDK-8247181
>
This looks good (and makes it consistent with DatagramChannel).
-Alan
More information about the net-dev
mailing list