RFR[15] JDK-8183369 : RFC unconformity of HttpURLConnection with proxy

[Daniel Fuchs]

Hi Ravi,

This looks good to me.

best regards,

-- daniel

On 02/03/2020 15:01, Ravi Reddy wrote:
> Hi Daniel,
> 
> As suggested by you I have added a test case for retry connection with proxy case . Please review the latest webrev and let me know your comments.
> 
> With the latest changes , the HttpURLConWithProxy test fails without the fix.
> 
> Webrev: http://cr.openjdk.java.net/~pkoppula/8183369/webrev.00/
> Issue: https://bugs.openjdk.java.net/browse/JDK-8183369
> 
> 
> Thanks,
> Ravi
> 
> 
> -----Original Message-----
> From: Ravi Reddy
> Sent: Thursday, February 13, 2020 10:10 PM
> To: Daniel Fuchs <daniel.fuchs at oracle.com>; Vyom Tiwari <vyommani at gmail.com>
> Cc: net-dev <net-dev at openjdk.java.net>
> Subject: RE: RFR[15] JDK-8183369 : RFC unconformity of HttpURLConnection with proxy
> 
> Hi Daniel/Vyom,
> 
> As mentioned in the review comments ,
>    Change in test case HttpURLConWithProxy.java is to make sure we don’t throw an error “Can’t use direct connection” even when the connection is made through proxy. i.e to make sure the existing test case won't fail because of the fix.
> 
> Daniel , As you suggested I will try and come up with a test case to make sure there is a retry happening after connection fails once through proxy.
> 
> 
> 
> Thanks,
> Ravi
> 
> -----Original Message-----
> From: Daniel Fuchs
> Sent: Thursday, February 13, 2020 8:59 PM
> To: Vyom Tiwari <vyommani at gmail.com>
> Cc: Ravi Reddy <ravi.k.reddy at oracle.com>; Chris Hegarty <chris.hegarty at oracle.com>; net-dev <net-dev at openjdk.java.net>
> Subject: Re: RFR[15] JDK-8183369 : RFC unconformity of HttpURLConnection with proxy
> 
> Thanks Vyom.
> 
> I was suspecting as much.
> 
> Ravi, could you come up with a test that fails without the fix and pass with it?
> 
> best regards,
> 
> -- daniel
> 
> 
> On 13/02/2020 14:26, Vyom Tiwari wrote:
>> Hi Ravi/Daniel,
>>
>> At my local env(REL 7) test is passing without fix as well. Although
>> my local repo contain some additional code changes but it is not
>> related with the current fix.
>> ################
>> Test1 Passed with: Connect timed out
>> Test2 Passed with: Connect timed out
>> ##################
>>
>> Please change copyright year(2020) as well.
>>
>> Thanks,
>> Vyom
>