[15] RFR 8241760 : Typos: empty lines in javadoc, inconsistent indents, etc. (net and nio)

Pavel Rappo pavel.rappo at oracle.com
Sun Mar 29 21:43:43 UTC 2020


Ivan,

1. ByteBuffered has an awkwardly looking top-level doc comment markup/formatting.
The "payload" begins on the same line as the /** marker. Also, the <p> tag is
weirdly placed. Since you have fixed similar issues already (URLConnection),
you could probably do the same here. Your call.

2. I know you probably wanted to confine this change to just the formatting,
but... maybe we could fix the "protocol handers" typo as an exception?

Other than that, the changes look good. Thanks for doing this!

-Pavel

> On 29 Mar 2020, at 05:44, Ivan Gerasimov <ivan.gerasimov at oracle.com> wrote:
> 
> Hello!
> 
> The fix follows up on JDK-8241727 [1].
> 
> This is a javadoc/comments only fix in the net and nio areas.
> 
> The changes are to remove redundant empty lines, correct indentation, or otherwise restore harmony.
> 
> Would you please help review this rather technical fix?
> 
> BUGURL: https://bugs.openjdk.java.net/browse/JDK-8241727
> WEBREV: http://cr.openjdk.java.net/~igerasim/8241727/00/webrev/
> 
> Thank in advance!
> 
> [1] https://bugs.openjdk.java.net/browse/JDK-8241727
> 
> -- 
> With kind regards,
> Ivan Gerasimov
> 



More information about the net-dev mailing list