RFR[8241072]: 'Reimplement Legacy DatagramSocket API'

[Alan Bateman]

On 31/03/2020 18:27, Chris Hegarty wrote:
> :
> - In DatagramSocket::createDelegate, "enable broadcast if possible” - Possibly due to refactoring, but I cannot reconcile this with the old implementation.
DatagramSocket is specified to make a best attempt to enable this option 
so I think it's in the right place. At a clean-up, the attempt in 
PDSI.datagramSocketCreate could be removed.

>
> :
>
> - The set of socket options is now per datagram/multicast socket instance, rather than on the class of the socket. I don’t think that this is an issue, just an observation and a confirmation that it is deliberate.
The set of socket options supported by a custom DSI will likely be 
different to the default impl so it needs to be an instance field. I 
suspect this is a long standing bug.

-Alan