RFR[8243488]: 'Add tests for set/get SendBufferSize and getReceiveBufferSize in DatagramSocket'

Alan Bateman Alan.Bateman at oracle.com
Fri May 1 19:29:29 UTC 2020


On 01/05/2020 16:53, Patrick Concannon wrote:
>
> Hi,
>
> I've refactored the test to use the name 'DatagramSocketSupplier' 
> instead of 'DSF' for the @FunctionalInterface, and used the supplier 
> method as Daniel suggested.
>
> The updates can be found in the patch below.
>
> http://cr.openjdk.java.net/~pconcannon/8243488/webrevs/webrev.03/
>
The tests looks good. Trivially you might to be consider renaming the 
"factory" to "supplier" as it's a bit strange to have a 
DatagramSocketSupplier named "factory".  No need for a new webrev if you 
take up that suggestion.

-Alan.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://mail.openjdk.java.net/pipermail/net-dev/attachments/20200501/b2e9deda/attachment.htm>


More information about the net-dev mailing list