RFR: 8244224: Implementation of JEP 381: Remove the Solaris and SPARC Ports - (core libraries)

[Mikael Vidstedt]

> On May 4, 2020, at 2:33 PM, Brent Christian <brent.christian at oracle.com> wrote:
> 
> Hi,
> 
> Looks fine to me.  I have just one minor observation:
> 
> src/java.base/share/native/libjli/emessages.h
> 
> *** 92,102 ****
>  #define JRE_ERROR5      "Error: Failed to start a %d-bit JVM process from a %d-bit JVM."
> ! #define JRE_ERROR6      "Error: Verify all necessary Java SE components have been installed.\n(Solaris SPARC 64-bit components must be installed after 32-bit components.)"
>  #define JRE_ERROR7      "Error: Either 64-bit processes are not supported by this platform\nor the 64-bit components have not been installed."
> --- 91,101 ----
>  #define JRE_ERROR5      "Error: Failed to start a %d-bit JVM process from a %d-bit JVM."
> ! #define JRE_ERROR6      "Error: Verify all necessary Java SE components have been installed.\n"
>  #define JRE_ERROR7      "Error: Either 64-bit processes are not supported by this platform\nor the 64-bit components have not been installed."
> 
> 
> The other error messages do not include a trailing newline.

Nice catch! Fixed in the upcoming webrev.

Thank you for this review - and the pre-review before it! :)

Cheers,
Mikael