RFR 8244652: Add test for non utf-8 response handling by websocket client

[Rahul]

Thanks Daniel
I would proceed with the push if there are no further comments.

On 13/05/2020, 12:39, "Daniel Fuchs" <daniel.fuchs at oracle.com> wrote:

    Hi Rahul,
    
    That looks good to me thanks!
    
    I am still teetering on whether we should also have altered the
    specification of WSHandshakeException, and explicitly changed the
    signature of WSHandshakeException::getResponse to return an
    HttpResponse<String> instead of an HttpResponse<?>.
    
    On the one hand - our implementation will now actually instantiate
    an HttpResponse<String>. On the other hand - it might not be fair
    to actually require it in the specification.
    
    Maybe Pavel will have some thoughts on the subject.
    
    As for me - your changes to the test look good.
    
    best regards
    
    -- daniel
    
    On 12/05/2020 20:05, Rahul wrote:
    > Hello,
    > 
    > Request to have my fix reviewed for the issue:
    > 
    >    JDK-8244652: Add test for non utf-8 response handling by websocket 
    > client.
    > 
    > The test java.net.httpclient.websocket.WSHandshakeExceptionTest.java is 
    > updated to test
    > 
    >    that the websocket client handles invalid utf-8 sent by the websocket 
    > server as part of the
    > 
    >    websocket exception whenthe handshake is rejected by websocket server.
    > 
    >    Issue:       https://bugs.openjdk.java.net/browse/JDK-8244652
    > 
    >    Webrev: 
    > http://cr.openjdk.java.net/~ryadav/webrev_8244652/webrev.00/index.html
    > 
    >   - rahul
    >