RFR: 8253005: Add `@throws IOException` in javadoc for `HttpEchange.sendResponseHeaders` [v3]

Patrick Concannon pconcannon at openjdk.java.net
Wed Nov 4 13:26:55 UTC 2020


On Wed, 4 Nov 2020 13:21:12 GMT, Chris Hegarty <chegar at openjdk.org> wrote:

>> Patrick Concannon has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains five additional commits since the last revision:
>> 
>>  - Merge remote-tracking branch 'origin/master' into JDK-8253005
>>  - Merge remote-tracking branch 'origin/master' into JDK-8253005
>>  - Merge remote-tracking branch 'origin/master' into JDK-8253005
>>  - Merge remote-tracking branch 'origin/master' into JDK-8253005
>>  - 8253005: Add `@throws IOException` in javadoc for `HttpEchange.sendResponseHeaders`
>
> Please add a new test that asserts the newly specified condition ( if the response headers have already been sent)  for where IOException can be thrown.

> Is there a test that asserts this: "if the response headers have already been sent" ?

Hi Chris, I can't see any test that checks this. I can write one and can upload it here.

-------------

PR: https://git.openjdk.java.net/jdk/pull/1014


More information about the net-dev mailing list