RFR: 8252304: Seed an HttpRequest.Builder from an existing HttpRequest [v3]

[Patrick Concannon]

On Wed, 4 Nov 2020 15:04:35 GMT, Chris Hegarty <chegar at openjdk.org> wrote:

>> Patrick Concannon has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains six additional commits since the last revision:
>> 
>>  - 8252304: Removed catch block from newBuilder(HttpRequest)
>>  - 8252304: assertBodyPublisherEqual added to test; added comment to newBuilder
>>  - Merge remote-tracking branch 'origin/master' into JDK-8252304
>>  - Merge remote-tracking branch 'origin/master' into JDK-8252304
>>  - Merge remote-tracking branch 'origin/master' into JDK-8252304
>>  - 8252304: Seed an HttpRequest.Builder from an existing HttpRequest
>
> src/java.net.http/share/classes/java/net/http/HttpRequest.java line 317:
> 
>> 315:      *         the given request (for instance, if the request contains illegal
>> 316:      *         parameters)
>> 317:      * @since TBD
> 
> Please add the specific release number, in this case `16`.

Release number added in commit https://github.com/openjdk/jdk/pull/1059/commits/7928083ae954c44b5357064b86af0e1a3f53588b

> test/jdk/java/net/httpclient/HttpRequestNewBuilderTest.java line 48:
> 
>> 46: * @bug 8252304
>> 47: * @summary HttpRequest.NewBuilder(HttpRequest) API and behaviour checks
>> 48: * @compile --enable-preview -source ${jdk.version} HttpRequestNewBuilderTest.java
> 
> records are now final so these command line args can be removed.

Command line arguments removed in commit https://github.com/openjdk/jdk/pull/1059/commits/7928083ae954c44b5357064b86af0e1a3f53588b

> src/java.net.http/share/classes/java/net/http/HttpRequest.java line 307:
> 
>> 305: 
>> 306:     /**
>> 307:      * Creates a {@code Builder} seeded from a {@code HttpRequest}.
> 
> We use *an* HttpXXX consistently elsewhere. Please do the same here.

Typo corrected in commit https://github.com/openjdk/jdk/pull/1059/commits/7928083ae954c44b5357064b86af0e1a3f53588b

-------------

PR: https://git.openjdk.java.net/jdk/pull/1059