RFR: 8253005: Add `@throws IOException` in javadoc for `HttpEchange.sendResponseHeaders` [v7]

[Chris Hegarty]

On Thu, 5 Nov 2020 17:56:00 GMT, Daniel Fuchs <dfuchs at openjdk.org> wrote:

>> test/jdk/java/net/httpclient/SendResponseHeadersTest.java line 99:
>> 
>>> 97:                     // unexpected exception thrown, return error to client
>>> 98:                     t.printStackTrace();
>>> 99:                     os.write(("Unexpected error: " + t).getBytes());
>> 
>> Hmm... I'd be tempted to drop this catch block altogether, it's not possible to know exactly what to do there? given that we don't know what the failure is.
>
> This is executed on the server side - the Throwable here is the AssertionError thrown by expectThrows if the expected exception is not thrown. It is important to return this to the client side so that the client side (main thread) can fail properly.

Oh, ok. So the whole purpose of the catch block is to gracefully terminate things (and trigger error reporting) if the test fails - which it should never do ;-) Ok, thanks.   [ It's almost like the code would be more easily understood if written without expectThrows, in this particular case ]

-------------

PR: https://git.openjdk.java.net/jdk/pull/1014