RFR: 8253005: Add `@throws IOException` in javadoc for `HttpEchange.sendResponseHeaders` [v7]

Patrick Concannon pconcannon at openjdk.java.net
Fri Nov 6 11:50:11 UTC 2020


On Fri, 6 Nov 2020 10:49:10 GMT, Daniel Fuchs <dfuchs at openjdk.org> wrote:

>> Oh, ok. So the whole purpose of the catch block is to gracefully terminate things (and trigger error reporting) if the test fails - which it should never do ;-) Ok, thanks.   [ It's almost like the code would be more easily understood if written without expectThrows, in this particular case ]
>
>>                      // unexpected exception thrown, return error to client 
> 
> The comment is a bit misleading. Maybe it should say:
> 
>                      // expectThrows triggered an assertion, return error message to the client.

Comment changed as requested. See https://github.com/openjdk/jdk/pull/1014/commits/8ff6d9b4fcbc0f57f136ff0e7df0d371664badb2

-------------

PR: https://git.openjdk.java.net/jdk/pull/1014


More information about the net-dev mailing list