RFR: 8255758: JEP 380 spec clarifications [v2]

Michael McMahon michaelm at openjdk.java.net
Tue Nov 17 11:53:18 UTC 2020


On Tue, 17 Nov 2020 11:25:22 GMT, Alan Bateman <alanb at openjdk.org> wrote:

>> Michael McMahon has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains five additional commits since the last revision:
>> 
>>  - spec update after Alan's comments
>>  - Merge branch 'master' into 8255758-spec-change
>>  - net-properties.html change only. src apidoc change to come
>>  - update to net-properties.html
>>  - 8255758: JEP 380 spec clarifications
>
> src/java.base/share/classes/java/net/doc-files/net-properties.html line 251:
> 
>> 249: with a {@code null} address parameter will bind to an <i>automatically assigned</i> socket address.
>> 250: For Unix domain sockets, this means a unique path in some predefined system temporary directory.
>> 251: <P>There are a number of system (and networking) properties that affect this behavior.
> 
> "There are are a number of system properties ..." follows directly from the previous sentence so I assume you don't want a paragraph break here.

Ok, that's fine.

> src/java.base/share/classes/java/net/doc-files/net-properties.html line 253:
> 
>> 251: <P>There are a number of system (and networking) properties that affect this behavior.
>> 252: <p>
>> 253: Bearing in mind that Unix domain socket addresses are limited in length to approximately 100 
> 
> I think "Bearing in mind" should be dropped here and just say that Unix domain sockets are typically limited to a file path of 100 characters (typically it is bytes that may be too subtle for the context).

Ok. Thanks

-------------

PR: https://git.openjdk.java.net/jdk/pull/1021


More information about the net-dev mailing list