RFR: 8252304: Seed an HttpRequest.Builder from an existing HttpRequest [v8]

[Daniel Fuchs]

On Tue, 17 Nov 2020 17:16:48 GMT, Michael McMahon <michaelm at openjdk.org> wrote:

>> Patrick Concannon has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains 15 additional commits since the last revision:
>> 
>>  - 8252304: Added more test cases to check header filter
>>  - Merge remote-tracking branch 'origin/master' into JDK-8252304
>>  - Merge remote-tracking branch 'origin/master' into JDK-8252304
>>  - 8252304: BiPredicate parameter added to newBuilder
>>  - Merge remote-tracking branch 'origin/master' into JDK-8252304
>>  - Merge remote-tracking branch 'origin/master' into JDK-8252304
>>  - Merge remote-tracking branch 'origin/master' into JDK-8252304
>>  - Merge remote-tracking branch 'origin/master' into JDK-8252304
>>  - Merge remote-tracking branch 'origin/master' into JDK-8252304
>>  - 8252304: Removed catch block from newBuilder(HttpRequest)
>>  - ... and 5 more: https://git.openjdk.java.net/jdk/compare/8c213bbb...03b13e7a
>
> src/java.net.http/share/classes/java/net/http/HttpRequest.java line 335:
> 
>> 333:      *  <li> Remove a particular header (e.g. Foo-Bar):
>> 334:      *  <pre>{@code HttpRequest.newBuilder(request, (name, value) -> name.equalsIgnoreCase("Foo-Bar"))}</pre>
>> 335:      * </ul>
> 
> Does the example above not result in "Foo-Bar" being the only header being copied across? So, maybe it should say "Retain a particular header"

Ah! Good catch - I believe the code is buggy. It should have been `!name.equalsIgnoreCase(...)`.

-------------

PR: https://git.openjdk.java.net/jdk/pull/1059