RFR: 8252304: Seed an HttpRequest.Builder from an existing HttpRequest [v8]

Patrick Concannon pconcannon at openjdk.java.net
Wed Nov 18 12:23:20 UTC 2020


On Tue, 17 Nov 2020 18:28:46 GMT, Daniel Fuchs <dfuchs at openjdk.org> wrote:

>> Ah! Good catch - I believe the code is buggy. It should have been `!name.equalsIgnoreCase(...)`.
>
> Patrick - can you add a test case with exactly **that** use case? I know you have similar tests which remove `"testName1"`, but it would be good to have a test that verifies that **the exact code** shown in the `@apiNote` works as expected. Your tests should have caught that mistake.

Well spotted, Michael. I've fixed that typo in the example, and added a test case to cover it. See commit https://github.com/openjdk/jdk/pull/1059/commits/68ea89e1c55735adc9230b8abc07e1df3ffc03ca

-------------

PR: https://git.openjdk.java.net/jdk/pull/1059


More information about the net-dev mailing list