RFR: 8253470: Javadoc clean up in Filter and Headers [v4]

Michael McMahon michaelm at openjdk.java.net
Thu Oct 1 14:31:05 UTC 2020


On Thu, 1 Oct 2020 12:03:04 GMT, Patrick Concannon <pconcannon at openjdk.org> wrote:

>> Hi,
>> 
>> Could someone please review my doc-only fix for JDK-8253470 - 'Javadoc clean up in Filter and Headers' ?
>> 
>> This fix is set of formatting changes intended to clean up the javadoc of the following classes :
>> 
>> `com.sun.net.httpserver.Filter`
>> `com.sun.net.httpserver.Filter.Chain`
>> `com.sun.net.httpserver.Headers`
>> 
>> This issue is a sub-task of [JDK-8252822](https://bugs.openjdk.java.net/browse/JDK-8252822)
>> 
>> Kind regards,
>> Patrick
>
> Patrick Concannon has updated the pull request with a new target base due to a merge or a rebase. The incremental
> webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains four additional commits
> since the last revision:
>  - 8253470: further formatting changes added
>  - Merge remote-tracking branch 'origin/master' into JDK-8253470
>  - Merge remote-tracking branch 'origin/master' into JDK-8253470
>  - 8253470: Javadoc clean up in Filter and Headers

Changes requested by michaelm (Reviewer).

src/jdk.httpserver/share/classes/com/sun/net/httpserver/Filter.java line 40:

> 38:  * are organised in chains, and are associated with {@link HttpContext} instances.
> 39:  *
> 40:  * <p> Each {@Filter} in the chain, invokes the next filter within its own

@Filter Is that supposed to be {@code Filter} or {@link Filter}?

-------------

PR: https://git.openjdk.java.net/jdk/pull/429


More information about the net-dev mailing list