RFR: 8253474: Javadoc clean up in HttpsExchange, HttpsParameters, and HttpsServer [v4]
Michael McMahon
michaelm at openjdk.java.net
Mon Oct 19 16:02:20 UTC 2020
On Mon, 19 Oct 2020 15:33:25 GMT, Patrick Concannon <pconcannon at openjdk.org> wrote:
>> Hi,
>>
>> Could someone please review my doc-only fix for JDK-8253474: 'Javadoc clean up in HttpsExchange, HttpsParameters, and
>> HttpsServer' ?
>> This fix is set of formatting changes intended to clean up the javadoc of the following classes :
>>
>> `com.sun.net.httpserver.HttpsExchange`
>> `com.sun.net.httpserver.HttpsParameters`
>> `com.sun.net.httpserver.HttpsServer`
>>
>> This issue is a sub-task of [JDK-8252822](https://bugs.openjdk.java.net/browse/JDK-8252822)
>>
>> Kind regards,
>> Patrick
>
> Patrick Concannon has updated the pull request with a new target base due to a merge or a rebase. The incremental
> webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains four additional commits
> since the last revision:
> - Merge remote-tracking branch 'origin/master' into JDK-8253474
> - 8253474: Comment added to default constructor; fixed punctuation in create(InetSocketAddress, int)
> - Merge remote-tracking branch 'origin/master' into JDK-8253474
> - 8253474: Javadoc clean up in HttpsExchange, HttpsParameters, and HttpsServer
src/jdk.httpserver/share/classes/com/sun/net/httpserver/HttpsParameters.java line 39:
> 37: * {@link HttpsConfigurator#configure(HttpsParameters)} for every incoming https
> 38: * connection,in order to determine the parameters to use.
> 39: *
looks like a space is missing between "connection,in"
src/jdk.httpserver/share/classes/com/sun/net/httpserver/HttpsParameters.java line 33:
> 31: import javax.net.ssl.SSLParameters;
> 32: //END_TIGER_EXCLUDE
> 33:
These TIGER EXCLUDE comments could be removed at this stage.
-------------
PR: https://git.openjdk.java.net/jdk/pull/610
More information about the net-dev
mailing list