RFR: 8255078: sun/net/ftp/imp/FtpClient$MLSxParser uses wrong datetime format

Igor Ignatyev iignatyev at openjdk.java.net
Fri Oct 23 17:37:36 UTC 2020


On Thu, 22 Oct 2020 16:04:56 GMT, Igor Ignatyev <iignatyev at openjdk.org> wrote:

>> Hi Igor, is this testable - and if so shouldn't there be a test?
>> best regards,
>> -- daniel
>
>> Hi Igor, is this testable - and if so shouldn't there be a test?
>> best regards,
>> -- daniel
> 
> Hi Daniel,
> 
> it's testable and originally I planned to add a new test, however upon checking the existing mock ftp-servers, I realized that none of them support MLSx commands, and adding that support doesn't seem to be justified for such a trivial fix. With that being said, I can create a test for this if you believe it's necessary.
> 
> -- Igor

I took another stab on the test and it turned out to be easier than I originally anticipated. I, however, decided to take a safer approach and don't use FtpServer` from `test/jdk/sun/net/www/ftptest` test-library, and instead introduced a test-specific mock server in the test code. I'm running the test multiple times on `{windows,linux,macosx}-x64` to check how stable it's in our environment, so far there are no failures.

-- Igor

-------------

PR: https://git.openjdk.java.net/jdk/pull/776


More information about the net-dev mailing list