RFR: 8253473: Javadoc clean up in HttpHandler, HttpPrincipal, HttpContext, and HttpsConfigurator [v3]

Patrick Concannon pconcannon at openjdk.java.net
Thu Oct 29 11:02:01 UTC 2020


On Wed, 28 Oct 2020 14:27:38 GMT, Daniel Fuchs <dfuchs at openjdk.org> wrote:

>> Patrick Concannon has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   8253473: Updated the @param for HttpPrincipal::getName; fixed @code tags
>
> src/jdk.httpserver/share/classes/com/sun/net/httpserver/HttpPrincipal.java line 57:
> 
>> 55:      * and realm are equal to this object's username and realm. Returns {@code false}
>> 56:      * otherwise.
>> 57:      *
> 
> Isn't this missing an @param for `another` ?

Well spotted. @param added in commit d8b93d01021d696f9f5272b1e6b34750dc36bcbf

> src/jdk.httpserver/share/classes/com/sun/net/httpserver/HttpPrincipal.java line 78:
> 
>> 76:     public String getName() {
>> 77:         return username;
>> 78:     }
> 
> Can you log a follow-up bug about this? It seems that the implementation just returns `username`, not `realm:username`.

I've created an issue for this as requested: https://bugs.openjdk.java.net/browse/JDK-8255584

-------------

PR: https://git.openjdk.java.net/jdk/pull/810


More information about the net-dev mailing list