RFR: 8251496: Fix doclint warnings in jdk.net.httpserver [v2]

Chris Hegarty chegar at openjdk.java.net
Wed Sep 9 15:33:59 UTC 2020


On Wed, 9 Sep 2020 08:50:38 GMT, Patrick Concannon <pconcannon at openjdk.org> wrote:

>> Hi,
>> 
>> Could someone please review my doc-only fix for JDK-8251496 - ‘Fix doclint warnings in jdk.net.httpserver’ ?
>> 
>> This fix addresses the warnings generated by `javadoc -Xdoclint` due to missing/incomplete API documentation for
>> several classes within `jdk.net.httpserver`.
>> Kind regards,
>> Patrick
>
> Patrick Concannon has updated the pull request with a new target base due to a merge or a rebase. The incremental
> webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains two additional commits
> since the last revision:
>  - Merge branch 'master' into JDK-8251496
>  - 8251496: Fix doclint warnings in jdk.net.httpserver

src/jdk.httpserver/share/classes/com/sun/net/httpserver/HttpExchange.java line 192:

> 190:      *        no response body may be written.
> 191:      * @throws IOException An IOException will be thrown if an error occurs during
> 192:      *         the sending of response headers, or if headers have already been sent.

> "or if headers have already been sent."

Maybe I missed it, but is there a test to assert this?  It is not obvious to me why this is being added now.

-------------

PR: https://git.openjdk.java.net/jdk/pull/81


More information about the net-dev mailing list