RFR: 8245309: Re-examine use of ThreadLocalCoders in sun.net.www.ParseUtil

Daniel Fuchs dfuchs at openjdk.java.net
Tue Sep 15 09:54:08 UTC 2020


On Tue, 15 Sep 2020 09:46:36 GMT, Alan Bateman <alanb at openjdk.org> wrote:

>> Replaced the use of ThreadLocalCoders with regular non-caching CharsetEncoder and added a benchmark to confirm that
>> there is no performance impact.
>
> src/java.base/share/classes/sun/net/www/ParseUtil.java line 181:
> 
>> 179:         CharBuffer cb = CharBuffer.allocate(n);
>> 180:         CharsetDecoder dec = UTF_8.INSTANCE.newDecoder()
>> 181:                 .onMalformedInput(CodingErrorAction.REPLACE)
> 
> This changes the error action from REPORT to REPLACE. This has implications for all usages of ParseUtil. Did you mean
> to do this?

Good catch Alan. I overlooked this. This should not be changed.

-------------

PR: https://git.openjdk.java.net/jdk/pull/170


More information about the net-dev mailing list